View Issue Details

IDProjectCategoryView StatusLast Update
0000222Siril[All Projects] Sirilpublic2018-02-15 13:33
ReportervinvinAssigned Tolock42 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.9.8 
Target Version0.9.8Fixed in Version0.9.8 
Summary0000222: Image number is not displayed for SER sequences
DescriptionBelow grey images, a text is displayed indicating which image is shown. The image index in the sequence is no longer shown in this text when the sequence is SER, and probably also for films. I think I've broken it in the past weeks.
TagsNo tags attached.

Activities

vinvin

2018-01-02 03:04

administrator   ~0000447

Oh in fact it's funnier: it's displayed for most SER but not for some (like the 8GB M57).

vinvin

2018-01-02 20:26

administrator   ~0000448

I don't know why it sometimes work, but the function that gets the displayed name is wrong: gui/callbacks.c display_filename(). It calls seq_get_image_filename() to get the proper full name but then calls g_path_get_basename() on this name, which removes the index.
I guess what we can do is create another function in sequence or add an argument to seq_get_image_filename() to do the basename before the formatting with the index.

lock42

2018-01-05 00:20

administrator   ~0000451

Fix committed to Siril (1972).

lock42

2018-01-05 21:11

administrator   ~0000452

Fix committed to Siril (1975).

Related Changesets

Siril: 0.9 r1972

2018-01-05 00:20:30

lock42

Details
Fixes 0000222 Affected Issues
0000222
mod - /branches/0.9/src/core/processing.c
mod - /branches/0.9/src/gui/callbacks.c
mod - /branches/0.9/src/gui/sequence_list.c
mod - /branches/0.9/src/io/sequence.c
mod - /branches/0.9/src/registration/registration.c
mod - /branches/0.9/src/stacking/stacking.c

Siril: 0.9 r1973

2018-01-05 00:50:55

lock42

Details
Reverting last commit.
Too many problems.
Affected Issues
0000222
mod - /branches/0.9/src/core/processing.c
mod - /branches/0.9/src/gui/callbacks.c
mod - /branches/0.9/src/gui/sequence_list.c
mod - /branches/0.9/src/io/sequence.c
mod - /branches/0.9/src/registration/registration.c
mod - /branches/0.9/src/stacking/stacking.c

Siril: 0.9 r1975

2018-01-05 21:11:40

lock42

Details
Trying to fix 0000222 by removing basename only in the display function. Affected Issues
0000222
mod - /branches/0.9/src/gui/callbacks.c
mod - /branches/0.9/src/gui/siril3.glade

Issue History

Date Modified Username Field Change
2018-01-02 02:16 vinvin New Issue
2018-01-02 03:04 vinvin Note Added: 0000447
2018-01-02 03:04 vinvin Severity text => tweak
2018-01-02 20:26 vinvin Status new => confirmed
2018-01-02 20:26 vinvin Note Added: 0000448
2018-01-05 00:20 lock42 Changeset attached => Siril 0.9 r1972
2018-01-05 00:20 lock42 Note Added: 0000451
2018-01-05 00:20 lock42 Assigned To => lock42
2018-01-05 00:20 lock42 Status confirmed => resolved
2018-01-05 00:20 lock42 Resolution open => fixed
2018-01-05 00:23 lock42 Fixed in Version => 0.9.8
2018-01-05 00:52 lock42 Changeset attached => Siril 0.9 r1973
2018-01-05 00:53 lock42 Assigned To lock42 =>
2018-01-05 00:53 lock42 Status resolved => acknowledged
2018-01-05 00:53 lock42 Resolution fixed => open
2018-01-05 09:49 vinvin Fixed in Version 0.9.8 =>
2018-01-05 09:49 vinvin Target Version 0.9.8 => 0.9.9
2018-01-05 21:11 lock42 Changeset attached => Siril 0.9 r1975
2018-01-05 21:11 lock42 Note Added: 0000452
2018-01-05 21:11 lock42 Assigned To => lock42
2018-01-05 21:11 lock42 Status acknowledged => resolved
2018-01-05 21:11 lock42 Resolution open => fixed
2018-01-05 21:11 lock42 Fixed in Version => 0.9.8
2018-02-15 13:29 lock42 Fixed in Version 0.9.8 => 0.9.8.3
2018-02-15 13:29 lock42 Target Version 0.9.9 => 0.9.8.3
2018-02-15 13:32 lock42 Product Version => 0.9.8
2018-02-15 13:32 lock42 Fixed in Version 0.9.8.3 => 0.9.8
2018-02-15 13:32 lock42 Target Version 0.9.8.3 =>
2018-02-15 13:33 lock42 Target Version => 0.9.8