View Issue Details

IDProjectCategoryView StatusLast Update
0000214Siril[All Projects] Sirilpublic2018-11-01 00:19
ReportervinvinAssigned Tovinvin 
PriorityhighSeverityminorReproducibilityN/A
Status assignedResolutionopen 
Product Version 
Target Version0.9.11Fixed in Version 
Summary0000214: High quality planetary registration
DescriptionMulti-point registration and stacking, or better.
See https://free-astro.org/index.php?title=Image_registration and https://github.com/GreatAttractor/stackistry
Mandatory for 1.0.
TagsNo tags attached.

Relationships

related to 0000021 assignedvinvin New feature - Split Siril into two modes 
related to 0000275 acknowledged Allow filtering of the stacked images from the command line 

Activities

vinvin

2017-12-26 22:32

administrator   ~0000444

The ECC registration algorithm generates a homography matrix. This is currently disabled because the seq file does not have a field for this piece of information; should we update it? In 0.9.9 we'll already have a change in the file format, maybe it's better to make all changes at once.

Related Changesets

Siril: mpp r2410

2018-06-12 03:11:56

vinvin

Details
Starting Siril MPP, nothing working yet (issue 0000214).
Moved some stuff from callbacks.c to new files.
New handling of the gtk builder to handle two mutually exclusive glade files.
Adding the centre of gravity registration, not yet tested nor in the GUI.
Affected Issues
0000214
mod - /branches/mpp/src/Makefile.am
mod - /branches/mpp/src/algos/colors.c
mod - /branches/mpp/src/algos/fft.c
mod - /branches/mpp/src/algos/gradient.c
mod - /branches/mpp/src/algos/quality.c
mod - /branches/mpp/src/compositing/align_rgb.c
mod - /branches/mpp/src/compositing/compositing.c
mod - /branches/mpp/src/core/command.c
mod - /branches/mpp/src/core/initfile.c
mod - /branches/mpp/src/core/proto.h
mod - /branches/mpp/src/core/siril.c
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/core/undo.c
mod - /branches/mpp/src/core/utils.c
mod - /branches/mpp/src/gui/PSF_list.c
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/callbacks.h
add - /branches/mpp/src/gui/gui.c
add - /branches/mpp/src/gui/gui.h
mod - /branches/mpp/src/gui/histogram.c
add - /branches/mpp/src/gui/image_display.c
add - /branches/mpp/src/gui/image_display.h
mod - /branches/mpp/src/gui/plot.c
mod - /branches/mpp/src/gui/registration_preview.c
mod - /branches/mpp/src/gui/save_dialog.c
mod - /branches/mpp/src/gui/script_menu.c
mod - /branches/mpp/src/gui/sequence_list.c
add - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/gui/statistics_list.c
mod - /branches/mpp/src/io/conversion.c
mod - /branches/mpp/src/io/image_formats_libraries.c
mod - /branches/mpp/src/io/sequence.c
mod - /branches/mpp/src/io/sequence_export.c
mod - /branches/mpp/src/io/ser.c
mod - /branches/mpp/src/io/single_image.c
mod - /branches/mpp/src/main.c
add - /branches/mpp/src/registration/cog.c
mod - /branches/mpp/src/registration/global.c
mod - /branches/mpp/src/registration/registration.c
mod - /branches/mpp/src/registration/registration.h
mod - /branches/mpp/src/stacking/stacking.c

Siril: mpp r2411

2018-06-12 22:06:49

vinvin

Details
Starting to fix things in the new GUI (issue 0000214, MPP): loading sequence and displaying it, menus, basic operations.
Affected Issues
0000214
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/gui.c
mod - /branches/mpp/src/gui/siril_planetary3.glade

Siril: mpp r2412

2018-06-13 02:31:10

vinvin

Details
MPP, issue 0000214: starting to have a reference image.
New COG registration working.
Modified sequence filters and registration layer in generic function, not yet ported everywhere.
GUI fixes and separator between the two sides of the main window.
Affected Issues
0000214
mod - /branches/mpp/src/Makefile.am
mod - /branches/mpp/src/algos/cosmetic_correction.c
add - /branches/mpp/src/algos/planetary.c
add - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/algos/quality.c
mod - /branches/mpp/src/algos/quality.h
mod - /branches/mpp/src/core/processing.c
mod - /branches/mpp/src/core/processing.h
mod - /branches/mpp/src/core/siril.c
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/gui.c
mod - /branches/mpp/src/gui/progress_and_log.c
mod - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/io/sequence.c
mod - /branches/mpp/src/io/sequence_export.c
mod - /branches/mpp/src/registration/cog.c
mod - /branches/mpp/src/registration/global.c
mod - /branches/mpp/src/registration/registration.c
mod - /branches/mpp/src/registration/registration.h
mod - /branches/mpp/src/stacking/stacking.c
mod - /branches/mpp/src/stacking/stacking.h
mod - /branches/mpp/src/stacking/sum.c

Siril: mpp r2413

2018-06-14 02:42:51

vinvin

Details
Various fixes in the generation of the reference image for planetary.
It now uses the correct layer operations and demosaiced input.
Issue 0000214.
Affected Issues
0000214
mod - /branches/mpp/src/algos/cosmetic_correction.c
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/quality.c
mod - /branches/mpp/src/algos/quality.h
mod - /branches/mpp/src/algos/star_finder.c
mod - /branches/mpp/src/core/command.c
mod - /branches/mpp/src/core/initfile.c
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/gui.c
mod - /branches/mpp/src/gui/gui.h
mod - /branches/mpp/src/gui/progress_and_log.c
mod - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/io/conversion.c
mod - /branches/mpp/src/io/seqfile.c
mod - /branches/mpp/src/main.c
mod - /branches/mpp/src/registration/cog.c
mod - /branches/mpp/src/registration/registration.c
mod - /branches/mpp/src/stacking/stacking.c

Siril: mpp r2415

2018-06-15 00:52:34

vinvin

Details
MPP (issue 0000214):
- reintroducing quality plot display with a new quality threshold line
- fixing the computation of thresholds from stacking filtering functions with incomplete registration data
- adding a slider to choose displayed image
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/plot.c
mod - /branches/mpp/src/gui/plot.h
mod - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/io/sequence_export.c
mod - /branches/mpp/src/registration/cog.c
mod - /branches/mpp/src/registration/registration.c
mod - /branches/mpp/src/stacking/stacking.c
mod - /branches/mpp/src/stacking/stacking.h

Siril: mpp r2416

2018-06-15 02:31:41

vinvin

Details
MPP (issue 0000214): allowing alignment points to be placed and removed manually.
Affected Issues
0000214
mod - /branches/mpp/src/Makefile.am
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/image_display.c
mod - /branches/mpp/src/gui/plot.c
mod - /branches/mpp/src/gui/siril_planetary3.glade

Siril: mpp r2417

2018-06-15 02:37:15

vinvin

Details
Almost forgot the two new files :) (issue 0000214).
Affected Issues
0000214
add - /branches/mpp/src/gui/planetary_callbacks.c
add - /branches/mpp/src/gui/planetary_callbacks.h

Siril: mpp r2423

2018-06-16 02:33:15

vinvin

Details
MPP (issue 0000214): thinking about the process and adding shift stats at the end of registration.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/quantize.c
mod - /branches/mpp/src/core/proto.h

Siril: mpp r2424

2018-06-16 10:38:17

vinvin

Details
adding the new glade to the make install - issue 0000214 Affected Issues
0000214
mod - /branches/mpp/Makefile.am
mod - /branches/mpp/config.guess
mod - /branches/mpp/config.sub

Siril: mpp r2425

2018-06-16 15:56:36

vinvin

Details
The multi-point registration. Issue 0000214.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/siril_planetary3.glade

Siril: mpp r2426

2018-06-17 01:15:39

vinvin

Details
MPP (issue 0000214): fixing activation of the processing button and displaying the reference image is available for layer.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/core/proto.h
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/planetary_callbacks.h
mod - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/io/image_format_fits.c
mod - /branches/mpp/src/stacking/stacking.c
mod - /branches/mpp/src/stacking/stacking.h

Siril: mpp r2427

2018-06-18 00:25:35

vinvin

Details
MPP (issue 0000214): exploring our implementation of FFTW and making it faster with a cache.
Reviewed initfile creation to have a generic configuration directory function, and it's probably faster too.
Affected Issues
0000214
mod - /branches/mpp/src/algos/fft.c
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/core/initfile.c
mod - /branches/mpp/src/core/proto.h
mod - /branches/mpp/src/core/utils.c
mod - /branches/mpp/src/gui/image_display.c
mod - /branches/mpp/src/io/sequence_export.c
mod - /branches/mpp/src/main.c
mod - /branches/mpp/src/registration/registration.c

Siril: mpp r2429

2018-06-22 21:32:55

vinvin

Details
The multi-point barycentric stacking.
The multi-point registration is not working well yet.
Issue 0000214.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/gui/callbacks.c
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/siril3.glade
mod - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/io/image_format_fits.c
mod - /branches/mpp/src/registration/registration.c
mod - /branches/mpp/src/stacking/stacking.c
mod - /branches/mpp/src/stacking/sum.c

Siril: mpp r2430

2018-06-23 01:10:22

vinvin

Details
Reviewing the DFT registration, which is actually called phase correlation.
Introducing a confidence factor for the registration data.
The resulting image has not improved much and is still far from the quality of the reference image.
Issue 0000214.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/registration/registration.c

Siril: mpp r2431

2018-06-23 23:56:27

vinvin

Details
Found the main issue in multi-point barycentre stacking, wrong variable used. Result is still not good.
Issue 0000214.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2432

2018-06-24 01:06:08

vinvin

Details
Issue 0000214: Fixing a bug on sequence or layer change and fixing display of graph and reg layer after sequence analysis.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2433

2018-06-25 23:16:15

vinvin

Details
Issue 0000214: implementing the multi-point registration based on ECC: not quite working with small zones.
Uncomment in the_multipoint_processing() to switch back to DFT phase correlation.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/gui/progress_and_log.c
mod - /branches/mpp/src/opencv/ecc/ecc.cpp
mod - /branches/mpp/src/opencv/ecc/ecc.h
mod - /branches/mpp/src/registration/cog.c
mod - /branches/mpp/src/registration/registration.c

Siril: mpp r2437

2018-07-06 23:43:33

vinvin

Details
Issue 0000214. Fixing zone size to have it as set in GUI.
Affected Issues
0000214
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/siril_planetary3.glade

Siril: mpp r2438

2018-07-13 15:16:28

lock42

Details
Fixes bug in the buffer copy Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2442

2018-07-19 02:45:58

vinvin

Details
A few fixes in the multi-point registration (issue 0000214).
Some parts still need to be verified.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/io/mp4_output.c
mod - /branches/mpp/src/io/sequence.c

Siril: mpp r2454

2018-08-29 01:57:49

vinvin

Details
fixing the three memory leaks in mpp, issue 0000214 Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/quality.c

Siril: mpp r2456

2018-09-03 00:08:32

vinvin

Details
MPP issue 0000214:
- fixing the major bug in the multipoint stacking, an ry instead of rx in the list of AP lead to area overwrite
- removing bad indicators peak and confidence
- removing the unused qtype argument to quality estimation and splitting the function in two for future use
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/algos/quality.c
mod - /branches/mpp/src/algos/quality.h
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/registration/cog.c
mod - /branches/mpp/src/registration/registration.c

Siril: mpp r2460

2018-09-06 01:47:52

vinvin

Details
New GUI for mpp (issue 0000214), new sequence analysis that evaluates zones quality and currently does nothing with it.
Highlighting zones from a list, graph is not yet modified.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/gui/image_display.c
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/plot.c
mod - /branches/mpp/src/gui/siril_planetary3.glade
mod - /branches/mpp/src/main.c

Siril: mpp r2467

2018-09-08 01:17:50

vinvin

Details
mpp, issue 0000214: showing graph for each stacking zone
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/planetary_callbacks.h
mod - /branches/mpp/src/gui/plot.c
mod - /branches/mpp/src/io/sequence.c

Siril: mpp r2471

2018-09-11 02:29:17

vinvin

Details
Probable working version for local mpp. Issue 0000214.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/core/proto.h
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/core/utils.c
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/gui/plot.c

Siril: mpp r2474

2018-09-12 01:40:01

vinvin

Details
A few fixes in mpp, issue 0000214, still not working.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/gui/planetary_callbacks.c

Siril: mpp r2475

2018-09-13 01:23:13

vinvin

Details
mpp: fixes, issue 0000213. A shift direction issue remains. Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/gui/planetary_callbacks.c

Siril: mpp r2478

2018-09-16 01:42:50

vinvin

Details
mpp: troubleshooting by documentation. Probably still not working well. Issue 0000214 Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2483

2018-09-19 01:41:38

vinvin

Details
mpp, issue 0000214: probable basic working fix!
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2484

2018-09-20 09:43:30

vinvin

Details
mpp, issue 0000214: probable fix for zone copy Affected Issues
0000214
mod - /branches/mpp/config.guess
mod - /branches/mpp/config.sub
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/registration/cog.c

Siril: mpp r2492

2018-09-28 03:05:11

vinvin

Details
Issue 0000214: cannot find the correct shift for zones after registration. Added some debug code, fails with all signs.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/opencv/ecc/ecc.cpp

Siril: mpp r2493

2018-10-02 00:19:09

vinvin

Details
issue 0000214 mpp: fixing the reference image (the_global_multipoint_barycentric_sum_stacking) and alignment of the local image generation relative to it (the_local_multipoint_sum_stacking).
Images seem to be aligned at last! Now we have to find how to make them look good :)
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2531

2018-10-29 02:26:14

vinvin

Details
mpp is getting close (issue 0000214): looks like the local stacking is going somewhere. global and other things around it are not updated to it yet.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/algos/planetary.h
mod - /branches/mpp/src/algos/statistics.c
mod - /branches/mpp/src/core/siril.h
mod - /branches/mpp/src/gui/planetary_callbacks.c
mod - /branches/mpp/src/io/ser.c
mod - /branches/mpp/src/opencv/ecc/ecc.cpp
mod - /branches/mpp/src/opencv/ecc/ecc.h
mod - /branches/mpp/src/opencv/opencv.cpp
mod - /branches/mpp/src/opencv/opencv.h
mod - /branches/mpp/src/registration/cog.c

Siril: mpp r2532

2018-10-29 23:44:25

vinvin

Details
Issue 0000214: unit test for the zone sorting function used in the_global_multipoint_barycentric_sum_stacking, it had an error.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
add - /branches/mpp/tests
add - /branches/mpp/tests/planetary.c

Siril: mpp r2533

2018-10-30 00:22:18

vinvin

Details
Issue 0000214 mpp: a slight improvement in global shifting, but there's still a small mismatch, probably in the local shift sign.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c

Siril: mpp r2535

2018-11-01 00:19:01

vinvin

Details
mpp (issue 0000214): discarding zones for which ECC failed.
Fixing a few things in homography, this mode is still not working.
Translation mode shows some inward alignment problems, I don't know where they come from.
Affected Issues
0000214
mod - /branches/mpp/src/algos/planetary.c
mod - /branches/mpp/src/opencv/ecc/ecc.cpp

Issue History

Date Modified Username Field Change
2017-12-02 23:02 vinvin New Issue
2017-12-02 23:02 vinvin Status new => acknowledged
2017-12-02 23:12 vinvin Description Updated View Revisions
2017-12-26 22:32 vinvin Note Added: 0000444
2018-05-18 01:14 vinvin Target Version 1.0.0 => 0.9.10
2018-06-12 03:10 vinvin Assigned To => vinvin
2018-06-12 03:10 vinvin Status acknowledged => assigned
2018-06-12 03:12 vinvin Changeset attached => Siril mpp r2410
2018-06-12 22:06 vinvin Changeset attached => Siril mpp r2411
2018-06-13 02:31 vinvin Changeset attached => Siril mpp r2412
2018-06-14 02:42 vinvin Changeset attached => Siril mpp r2413
2018-06-14 02:54 vinvin Relationship added related to 0000021
2018-06-15 00:52 vinvin Changeset attached => Siril mpp r2415
2018-06-15 02:31 vinvin Changeset attached => Siril mpp r2416
2018-06-15 02:37 vinvin Changeset attached => Siril mpp r2417
2018-06-16 02:33 vinvin Changeset attached => Siril mpp r2423
2018-06-16 10:38 vinvin Changeset attached => Siril mpp r2424
2018-06-16 15:56 vinvin Changeset attached => Siril mpp r2425
2018-06-17 01:15 vinvin Changeset attached => Siril mpp r2426
2018-06-18 00:25 vinvin Changeset attached => Siril mpp r2427
2018-06-22 21:32 vinvin Changeset attached => Siril mpp r2429
2018-06-23 01:10 vinvin Changeset attached => Siril mpp r2430
2018-06-23 23:56 vinvin Changeset attached => Siril mpp r2431
2018-06-24 01:06 vinvin Changeset attached => Siril mpp r2432
2018-06-25 23:16 vinvin Changeset attached => Siril mpp r2433
2018-07-06 23:43 vinvin Changeset attached => Siril mpp r2437
2018-07-13 15:25 lock42 Changeset attached => Siril mpp r2438
2018-07-19 02:46 vinvin Changeset attached => Siril mpp r2442
2018-08-29 01:57 vinvin Changeset attached => Siril mpp r2454
2018-09-03 00:08 vinvin Changeset attached => Siril mpp r2456
2018-09-06 01:47 vinvin Changeset attached => Siril mpp r2460
2018-09-08 01:17 vinvin Changeset attached => Siril mpp r2467
2018-09-11 02:29 vinvin Changeset attached => Siril mpp r2471
2018-09-12 01:40 vinvin Changeset attached => Siril mpp r2474
2018-09-13 01:24 vinvin Changeset attached => Siril mpp r2475
2018-09-16 01:42 vinvin Changeset attached => Siril mpp r2478
2018-09-19 01:41 vinvin Changeset attached => Siril mpp r2483
2018-09-20 09:43 vinvin Changeset attached => Siril mpp r2484
2018-09-27 22:31 vinvin Relationship added related to 0000275
2018-09-28 03:05 vinvin Changeset attached => Siril mpp r2492
2018-10-02 00:19 vinvin Changeset attached => Siril mpp r2493
2018-10-29 02:26 vinvin Changeset attached => Siril mpp r2531
2018-10-29 23:44 vinvin Changeset attached => Siril mpp r2532
2018-10-30 00:22 vinvin Changeset attached => Siril mpp r2533
2018-10-30 09:07 lock42 Target Version 0.9.10 => 0.9.11
2018-11-01 00:19 vinvin Changeset attached => Siril mpp r2535