View Issue Details

IDProjectCategoryView StatusLast Update
0000127Siril[All Projects] Sirilpublic2018-01-07 02:48
ReportervinvinAssigned Tovinvin 
PriorityhighSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.9.3 
Target Version0.9.8Fixed in Version0.9.8 
Summary0000127: SER processing of partial image is slow
DescriptionPartial images for SER are obtained as entire image then cropped.
Would be faster to directly read the right data.

However, this is only used for PSF right now, probably not the kind of function used with SER.
TagsNo tags attached.

Activities

vinvin

2017-11-20 23:43

administrator   ~0000420

Is it still the case? I've seen code that does just that.

vinvin

2018-01-01 23:01

administrator   ~0000446

It's incredibly slow to do a seqpsf on SER, I checked the code and it still extracts the entire image to crop it afterwards, we're constantly waiting on I/O and crop to do something, this is bad. I'll try to fix it very soon.

vinvin

2018-01-07 02:47

administrator   ~0000454

Fix committed to Siril (1977).

Related Changesets

Siril: 0.9 r1977

2018-01-07 02:47:56

vinvin

Details
The big partial SER and new_fit_image update.
Fixes 0000127 'SER processing of partial image is slow'.
Probably fixes 0000223 'seqpsf fails the second time' by adding the required user feedback messages.
Rewrote new_fit_image that is widely used, may break a few things.
SER partial read is much faster for any type of SER. It is now used in the generic function (used by seqpsf) and in median and rejection stacking.
Affected Issues
0000127, 0000223
mod - /branches/0.9/src/algos/fft.c
mod - /branches/0.9/src/core/command.c
mod - /branches/0.9/src/core/processing.c
mod - /branches/0.9/src/core/proto.h
mod - /branches/0.9/src/core/siril.c
mod - /branches/0.9/src/gui/callbacks.c
mod - /branches/0.9/src/io/image_format_fits.c
mod - /branches/0.9/src/io/sequence.c
mod - /branches/0.9/src/io/ser.c
mod - /branches/0.9/src/io/ser.h
mod - /branches/0.9/src/registration/registration.c
mod - /branches/0.9/src/stacking/stacking.c
mod - /branches/0.9/src/stacking/sum.c

Issue History

Date Modified Username Field Change
2016-04-18 01:56 vinvin New Issue
2016-04-18 01:56 vinvin Status new => assigned
2016-04-18 01:56 vinvin Assigned To => vinvin
2016-12-19 16:32 lock42 Category General => Software Development
2016-12-19 16:50 lock42 Category Software Development => Software
2016-12-19 23:30 lock42 Category Software => Siril
2017-11-20 23:43 vinvin Note Added: 0000420
2017-11-20 23:43 vinvin Assigned To vinvin =>
2017-11-20 23:43 vinvin Status assigned => feedback
2018-01-01 22:59 vinvin Assigned To => vinvin
2018-01-01 22:59 vinvin Status feedback => assigned
2018-01-01 23:01 vinvin Priority low => high
2018-01-01 23:01 vinvin Target Version 1.0.0 => 0.9.9
2018-01-01 23:01 vinvin Note Added: 0000446
2018-01-05 21:51 lock42 Target Version 0.9.9 => 0.9.8
2018-01-07 02:47 vinvin Changeset attached => Siril 0.9 r1977
2018-01-07 02:48 vinvin Note Added: 0000454
2018-01-07 02:48 vinvin Status assigned => resolved
2018-01-07 02:48 vinvin Resolution open => fixed
2018-01-07 02:48 vinvin Fixed in Version => 0.9.8